altTab: Move input focus to target window before dropping the grab

We chain up on _finish() to drop the grab and destroy the switcher
popup but we should activate the target window first because dropping
the grab results in the previously focused windows getting a focus in
event immediately followed by the focus out event from the target
window activation which we can easily avoid.

https://bugzilla.gnome.org/show_bug.cgi?id=696259

diff --git a/js/ui/altTab.js b/js/ui/altTab.js
index d6f6a957254d69b8cad70d98f3536d12d8e3bba4..4b62f5c7159ffbf49ac3547db9cff55f02ef594d 100644 (file)
--- a/js/ui/altTab.js
+++ b/js/ui/altTab.js
@@ -232,11 +232,11 @@ const AppSwitcherPopup = new Lang.Class({
     },
 
     _finish : function(timestamp) {
-        this.parent();
-
         let appIcon = this._items[this._selectedIndex];
         let window = this._currentWindow > 0 ? this._currentWindow : 0;
         appIcon.app.activate_window(appIcon.cachedWindows[window], timestamp);
+
+        this.parent();
     },
 
     _onDestroy : function() {
@@ -395,9 +395,9 @@ const WindowSwitcherPopup = new Lang.Class({
     },
 
     _finish: function() {
-        this.parent();
-
         Main.activateWindow(this._items[this._selectedIndex].window);
+
+        this.parent();
     }
 });